Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generator to use WHAT variable #1127

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Update generator to use WHAT variable #1127

merged 1 commit into from
Sep 26, 2017

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Sep 25, 2017 •
edited
Loading

Having to set two different variables is confusing. Changed this to look at the WHAT envvar and match on a suffix.

Fixes #1126.

cc: @jamiehannaford

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2017
@cblecker cblecker mentioned this pull request Sep 25, 2017
Closed
@mattfarina
Copy link
Contributor

I like this approach. lgtm

@mattfarina
Copy link
Contributor

Note, I did manually test this and verified that it works for me.

jamiehannaford
jamiehannaford approved these changes Sep 26, 2017
View reviewed changes
Copy link
Contributor

@jamiehannaford jamiehannaford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cblecker
Copy link
Member Author

Self-LGTM based on comments :)

@cblecker cblecker added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue. .

@k8s-github-robot k8s-github-robot merged commit f0f37f4 into kubernetes:master Sep 26, 2017
@cblecker cblecker deleted the generator-what branch September 26, 2017 20:39
danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
@zirain
update zirain's association (kubernetes#1127)
819f2d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehannaford jamiehannaford jamiehannaford approved these changes

Assignees

@calebamiles calebamiles

@vishh vishh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cblecker @mattfarina @k8s-github-robot @jamiehannaford @calebamiles @vishh @k8s-ci-robot